Finding dependencies in config files

Alexander Neundorf neundorf at kde.org
Sat Feb 16 08:43:52 UTC 2013


On Saturday 16 February 2013, Stephen Kelly wrote:
> commit 6bf0ad9fc7807f341ca924235d2f1e54b8038881
> Author: Alex Neundorf <neundorf at kde.org>
> Date:   Sat Feb 9 18:50:06 2013 +0100
> 
>     kguiaddons: check that kconfig has been found in the Config.cmake file
> 
>     Alex
> 
> diff --git a/staging/kguiaddons/kguiaddonsConfig.cmake.in
> b/staging/kguiaddons/kguiaddonsConfig.cmake.in
> index 8f1278f..325ef2c 100644
> --- a/staging/kguiaddons/kguiaddonsConfig.cmake.in
> +++ b/staging/kguiaddons/kguiaddonsConfig.cmake.in
> @@ -2,6 +2,12 @@
> 
>  # Any changes in this file will be overwritten by CMake.
> 
> +if(NOT TARGET KF5::kconfigcore)
> +   set(kconfig_NOT_FOUND_MESSAGE "kguiaddons depends on the package
> kconfig, which is missing. Use find_package() to find it before
> kguiaddons.")
> +   set(kconfig_FOUND FALSE)
> +   return()
> +endif()
> 
> 
> Still, the correct approach is to find_package the dependencies in the
> config file. Do you have some objection to doing so?

No, not at all :-)
As I said, this is just the quick fix.

Alex


More information about the Kde-frameworks-devel mailing list