Build failed in Jenkins: kdelibs_frameworks_qt5 #403

[Stephen Kelly]

Alexander Neundorf wrote:

> Hi Stephen,
> 
> On Saturday 16 February 2013, Stephen Kelly wrote:
>> KDE CI System wrote:
>> > CMake Error at
>> > /srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-
>> 
>> modules/master/share/ECM-0.0.7/kde-modules/KDECompilerSettings.cmake:404
>> 
>> > (message): Qt compiled without support for -fvisibility=hidden.  This
>> > will break plugins and linking of some applications.  Please fix your
>> > Qt installation (try passing --reduce-exports to configure). Call Stack
>> > (most recent call first):
>> > /srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-
>> 
>> modules/master/share/ECM-0.0.7/find-modules/FindKF5.cmake:94
>> 
>> > (include) CMakeLists.txt:60 (find_package)
>> 
>> There should be no need to test for visibility=hidden. QtCoreConfig
>> defines QT_VISIBILITY_AVAILABLE already.
> 
> Ok, so this try_compile() can go away, right ?

Yes. Adding that setting to the file is something you requested and I added 
long ago :). Please have a look at the Qt5 Config files so that you're not 
duplicating.

> 
> What's the deal with the fPIE and/or fPIC settings ?
> You also did something related to them, right ?

More importantly, Qt requires dependencies to be built using PIE by default. 
Having an option for that in KDE doesn't make a lot of sense.

Look at the POSITION_INDEPENDENT_CODE property since 2.8.9, the 
INTERFACE_POSITION_INDEPENDENT_CODE property since master, and look at 
https://codereview.qt-project.org/#change,46437 which can go in when 2.8.11 
is released. In general, be aware of what's coming so that you're not doing 
things that will be obsolete when 2.8.11 comes.

Thanks,

Steve.