Patch: Move kprotocolmanager to kiocore.

[Jignesh Kakadiya]

Hi David,

Here is the first patch which removes QGuiAppliction from kprotocolmanager.
Please review it.

Thanks,
Jignesh


On Mon, Feb 11, 2013 at 10:45 PM, David Faure <faure at kde.org> wrote:

> On Monday 11 February 2013 21:59:44 Jignesh Kakadiya wrote:
> > Hi David,
> >
> > It moves kprotocolmanager from kio/kio to kiocore. Builds successfully.
> > Please review it.
>
> You should make two commits: one which moves the code, and one which makes
> changes to the code (like the QGuiApplication dependency thing).
>
> I don't mind if the commit that moves the code, makes simple adjustements
> like
> changing export macros, I've done that before (and my script does that).
> But other changes should be separate, so that they can be reviewed.
>
> On that note I think you got that bit wrong: you should get rid of the #if
> QT_VERSION blocks, and only keep the code you want to keep
> (which, in kprotocolmanager.cpp, is the code that doesn't use
> QGuiApplication)
>
> --
> David Faure, faure at kde.org, http://www.davidfaure.fr
> Working on KDE, in particular KDE Frameworks 5
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130212/5dedd3cd/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: remove_QGuiApplication.patch
Type: application/octet-stream
Size: 1368 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130212/5dedd3cd/attachment.obj>