Review Request 108875: Port Sonnet to QPluginLoader
David Faure
faure at kde.org
Sat Feb 9 18:36:02 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108875/#review27092
-----------------------------------------------------------
Ship it!
Ship It!
staging/sonnet/src/core/CMakeLists.txt
<http://git.reviewboard.kde.org/r/108875/#comment20434>
remove comment about kservice, or remove kconfig dependency altogether if now unused
- David Faure
On Feb. 9, 2013, 6:30 p.m., Martin Tobias Holmedahl Sandsmark wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108875/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2013, 6:30 p.m.)
>
>
> Review request for KDE Frameworks and kdelibs.
>
>
> Description
> -------
>
> Port Sonnet to use QPluginLoader instead of KServiceTypeTrader/KPluginLoader.
>
>
> Diffs
> -----
>
> staging/sonnet/src/core/CMakeLists.txt fcbbbe1
> staging/sonnet/src/core/loader.cpp bd64e2a
> staging/sonnet/src/core/loader_p.h 896a8f8
> staging/sonnet/src/plugins/aspell/CMakeLists.txt 2f7c4bd
> staging/sonnet/src/plugins/aspell/kspell_aspell.desktop aa22c1b
> staging/sonnet/src/plugins/enchant/CMakeLists.txt e3365cf
> staging/sonnet/src/plugins/enchant/kspell_enchant.desktop 4cee638
> staging/sonnet/src/plugins/hspell/CMakeLists.txt 9e7bf13
> staging/sonnet/src/plugins/hspell/kspell_hspell.desktop 929e843
> staging/sonnet/src/plugins/hunspell/CMakeLists.txt 3f8a30c
> staging/sonnet/src/plugins/hunspell/kspell_hunspell.desktop 94ea5ed
>
> Diff: http://git.reviewboard.kde.org/r/108875/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Tobias Holmedahl Sandsmark
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130209/250fbc32/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list