Find Phonon4Qt5 gets confused
David Faure
faure+bluesystems at kde.org
Sat Feb 9 09:38:14 UTC 2013
On Friday 08 February 2013 22:49:13 Alexander Neundorf wrote:
> On Monday 04 February 2013, David Faure wrote:
> > On Monday 04 February 2013 09:09:25 Treeve Jelbert wrote:
> > > On Sun, 03 Feb 2013 18:35:43 +0100, David Faure wrote:
> > > > On Sunday 03 February 2013 10:25:58 Treeve Jelbert wrote:
> > > >> cmake/modules/FindKDE4Internal.cmake:find_package(Phonon 4.3.80)
> > > >
> > > > Good point. Can you try removing that from FindKDE4Internal?
> > > >
> > > > (at some point we'll get rid of FindKDE4Internal completely, but at
> > > > this point
> > > > it's too early, not everything is ported to kf5).
> > >
> > > removing that check fixes things
> >
> > Applied, thanks!
>
> Phonon installs a Phon4Qt5Config.cmake file, I assume ?
Yep.
The kdelibs code was still checking for PHONON_FOUND though... I just fixed
that, and adjusted include dirs and lib names so that phonon4qt5 is actually
found.
If you feel like doing more buildsystem cleanups, phonon4qt5 is a prime
target... (e.g. it still has a copy of many macros which are now in cmake, I
think)
--
David Faure, faure at kde.org, http://www.davidfaure.fr
Sponsored by BlueSystems and KDAB to work on KDE Frameworks
More information about the Kde-frameworks-devel
mailing list