Review Request 105868: KF5 - Q_OS_* not defined
Commit Hook
null at kde.org
Thu Feb 7 22:40:19 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105868/#review26922
-----------------------------------------------------------
This review has been submitted with commit b5767214c579a69d0c6fd72fbed10ff93286502a by Albert Astals Cid on behalf of Andrius da Costa Ribas to branch frameworks.
- Commit Hook
On Aug. 5, 2012, 10:28 p.m., Andrius da Costa Ribas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105868/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2012, 10:28 p.m.)
>
>
> Review request for KDE Frameworks and kdewin.
>
>
> Description
> -------
>
> Q_OS_WIN & Q_OS_MAC not defined at that point, replacing with WIN32 and APPLE.
>
>
> Diffs
> -----
>
> kde3support/KDE3SupportMacros.cmake a4f44e2
> kdecore/CMakeLists.txt e5cbd19
> kded/CMakeLists.txt fb204e8
> kdeui/CMakeLists.txt 7849b52
> kdeui/KDEUIMacros.cmake d5c20d9
> kinit/CMakeLists.txt 3c283a6
> tier1/kidletime/src/CMakeLists.txt 973d623
> tier1/kwindowsystem/src/CMakeLists.txt 96cb3dd
>
> Diff: http://git.reviewboard.kde.org/r/105868/diff/
>
>
> Testing
> -------
>
> Got undefined references before the fix.
>
>
> Thanks,
>
> Andrius da Costa Ribas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130207/fc9e471e/attachment.html>
More information about the Kde-frameworks-devel
mailing list