Issues porting KGeography to KF5

[David Faure]

On Tuesday 31 December 2013 00:52:59 David Gil Oliva wrote:
> Hi!
> 
> I'm porting KGeography to KF5, and I found some issues.
> 
> *KConfigDialog::setHelp()*
> 
> KConfigDialog* dialog = new KConfigDialog(this, "settings",
> kgeographySettings::self());
> dialog->setHelp("configuration", "kgeography");
> 
> It gives me the following error:
> 
> /home/david/devel/kgeography/src/kgeography.cpp:170:13: error: ‘class
> KConfigDialog’ has no member named ‘setHelp’
> make[2]: *** [src/CMakeFiles/kgeography.dir/kgeography.cpp.o] Error 1
> make[1]: *** [src/CMakeFiles/kgeography.dir/all] Error 2
> make: *** [all] Error 2
> 
> What should I subtitute it for? Or should I drop it?

Kévin? Is the help button missing in your port of KPageDialog to QDialogButtonBox?

> *KApplication::setTopWidget()*
> Should I drop it? Is there anything I can substitute it for?

I looked into this one, and documented the answer:


diff --git a/src/kdeui/kapplication.h b/src/kdeui/kapplication.h
index af026e8..474ec8c 100644
--- a/src/kdeui/kapplication.h
+++ b/src/kdeui/kapplication.h
@@ -208,7 +208,11 @@ public:
      *  @param topWidget A top widget of the application.
      *
      *  @see icon(), caption()
-     **/
+     * @deprecated since 5.0. This was doing two things: 1) setting the window title to
+     * include the appname; Qt now takes care of that on platforms where this is wanted.
+     * 2) setting the window startup ID, which Qt should take care of in the future.
+     * -> simply remove this call.
+     */
     void setTopWidget(QWidget *topWidget);
 


-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5