Review Request 114693: fix KFileWidget url selection

[Michal Humpula]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114693/
-----------------------------------------------------------

(Updated Dec. 30, 2013, 9 p.m.)


Review request for KDE Frameworks.


Changes
-------

ok, so here comes another version. Same result. Fixes the problem with passing startDir = QUrl::fromLocalFile("/etc/passwd"); showing incorrect folder. I think I could write a testcase for this.


Repository: kio


Description
-------

If I understand correctly documentation of KFileWidget, it should be perfectly ok to do something like this:

KEncodingFileDialog::getOpenUrlsAndEncoding(QString(), 
QUrl("file:///etc/passwd"));

But that doesn't display the thing I'm expecting. Tracing it down I came up with the fix. I'm not claiming that it's the correct one, but at least in my situation the KFileWidget behaves as expected in all tested situations. 

Surprisingly the

void KFileWidgetPrivate::setLocationText(const QList<QUrl> &urlList)

doesn't call any setUrl, which hints that it could actually be correct.


Diffs (updated)
-----

  src/filewidgets/kfilewidget.cpp 11597b3 

Diff: https://git.reviewboard.kde.org/r/114693/diff/


Testing
-------


Thanks,

Michal Humpula

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131230/858ff0d9/attachment.html>