Review Request 114693: fix KFileWidget url selection

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114693/#review46448
-----------------------------------------------------------


This looks wrong to me. This code was in KFileWidget in kde4 already. OTOH the port of KEncodingFileDialog to KFileWidget is what's new in frameworks.
So I'd be quite tempted to say that the bug is in the way KEncodingFileDialog uses KFileWidget, unless you can prove otherwise :)
I'm afraid that changing this will break KFileWidget/KFileDialog.

- David Faure


On Dec. 28, 2013, 11:33 a.m., Michal Humpula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114693/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2013, 11:33 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> If I understand correctly documentation of KFileWidget, it should be perfectly ok to do something like this:
> 
> KEncodingFileDialog::getOpenUrlsAndEncoding(QString(), 
> QUrl("file:///etc/passwd"));
> 
> But that doesn't display the thing I'm expecting. Tracing it down I came up with the fix. I'm not claiming that it's the correct one, but at least in my situation the KFileWidget behaves as expected in all tested situations. 
> 
> Surprisingly the
> 
> void KFileWidgetPrivate::setLocationText(const QList<QUrl> &urlList)
> 
> doesn't call any setUrl, which hints that it could actually be correct.
> 
> 
> Diffs
> -----
> 
>   src/filewidgets/kfilewidget.cpp 11597b3 
> 
> Diff: https://git.reviewboard.kde.org/r/114693/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michal Humpula
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131230/ae5cef35/attachment.html>