Review Request 114726: Make sure ktoolbar_unittest does not depend on global icon settings

Alex Merry kde at randomguy3.me.uk
Sun Dec 29 18:04:28 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114726/
-----------------------------------------------------------

(Updated Dec. 29, 2013, 6:04 p.m.)


Review request for KDE Frameworks.


Repository: kxmlgui


Description (updated)
-------

Make sure ktoolbar_unittest does not depend on global icon settings

ktoolbar_unittest should not be testing the default settings of
KIconTheme anyway.


NB: I am away until 2nd Jan, so if it gets a "ship it", feel free to commit it in my absence in order to get Jenkins green again.


Diffs
-----

  autotests/ktoolbar_unittest.cpp 2ee490d35b517a8121aa0aeda0d6ebb4256caad0 

Diff: https://git.reviewboard.kde.org/r/114726/diff/


Testing
-------

Tests pass on my local machine (but they did before as well).


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131229/d9eeecb4/attachment.html>


More information about the Kde-frameworks-devel mailing list