Review Request 114727: Unconditionally skip ICU-dependent encoding tests in kcharsettest

Alex Merry kde at randomguy3.me.uk
Sun Dec 29 17:02:29 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114727/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kcodecs


Description
-------

Unconditionally skip ICU-dependent encoding tests
    
Qt 5.2 and the current 5.3 dev branch have still not resolved the issue
of certain encodings only being available if Qt was compiled with ICU
support.  Since we do not know when it will be fixed, always skip this
part of the test regardless of the Qt version.  This can be resolved as
and when the issue is fixed in Qt.


Diffs
-----

  autotests/kcharsetstest.cpp 98039249d4e44e43b6cada614a4352367ea57c05 

Diff: https://git.reviewboard.kde.org/r/114727/diff/


Testing
-------

Still compiles, kcharsettest still runs.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131229/bac03d68/attachment.html>


More information about the Kde-frameworks-devel mailing list