Review Request 114703: Improve dependency specification for kdesignerplugin

Alex Merry kde at randomguy3.me.uk
Sat Dec 28 17:37:17 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114703/
-----------------------------------------------------------

(Updated Dec. 28, 2013, 5:37 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdesignerplugin


Description
-------

Improve dependency specification

* Add a find_package for Qt5WebKitWidgets
* Make most frameworks deps optional (so it is possible to just build
  the kgendesignerplugin utility, and not the actual plugins)
* Get rid of the cruft from when it was in the kdelibs repo


NB: this doesn't need to go into TP1, but if I don't post these patches, I'll forget I have them.


Diffs
-----

  CMakeLists.txt 38424b468d97532ffd1d19bc353c92b29a9f38b0 
  src/CMakeLists.txt 3e51888614358e71756774f6bbfd5d3c14921947 

Diff: https://git.reviewboard.kde.org/r/114703/diff/


Testing
-------

Still builds fine.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131228/8ee511a8/attachment.html>


More information about the Kde-frameworks-devel mailing list