Review Request 114701: Print a warning if kimagecache.h is used without KF5::CoreAddons

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114701/
-----------------------------------------------------------

(Updated Dec. 28, 2013, 1:53 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kguiaddons


Description
-------

Print a warning if kimagecache.h is used without KF5::CoreAddons

If an application links against KF5::GuiAddons but not KF5::CoreAddons,
they cannot use KImageCache.  So we use defines (set by the exported
targets) to check whether the current target has been linked against
KF5::CoreAddons, and print a warning if not (to explain the expected
"kshareddatacache.h not found" error).


Diffs
-----

  src/CMakeLists.txt d6ee3d9987319f9a3d1f8b2f66e00d2ec4bda1e5 
  src/util/kimagecache.h 007891c757de9bedc5cf0c3b734e250004727ec4 

Diff: https://git.reviewboard.kde.org/r/114701/diff/


Testing
-------

plasma-framework (which uses KImageCache) still builds fine.  If an older version of KCoreAddons (without the KCOREADDONS_LIB define) is installed, a warning is printed when kimagecache.h is included.  If the patch in review 114700 is applied to KCoreAddons, the warning is not printed.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131228/58b9c87d/attachment.html>