Review Request 114683: Clean up target_link_libraries for KF5Plasma

Commit Hook null at kde.org
Fri Dec 27 16:29:35 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114683/#review46194
-----------------------------------------------------------


This review has been submitted with commit 778bf0ac0b057db1906d95c6fe7d89b6215d896b by Alex Merry to branch master.

- Commit Hook


On Dec. 27, 2013, 2:43 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114683/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2013, 2:43 p.m.)
> 
> 
> Review request for Build System, KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Clean up target_link_libraries for KF5Plasma
> 
> It is now a single call using PUBLIC and PRIVATE keywords.  This removes
> a CMake warning about using LINK_INTERFACE_LIBRARIES.
> 
> 
> Diffs
> -----
> 
>   src/plasma/CMakeLists.txt 5a6ceabb3d6b95fb792e19aab034b87d0dd688a9 
> 
> Diff: https://git.reviewboard.kde.org/r/114683/diff/
> 
> 
> Testing
> -------
> 
> plasma-framework and kde-workspace both still compile.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131227/3baa2c72/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list