Review Request 114478: Add kshareddatacache.h include

Alex Merry kde at randomguy3.me.uk
Fri Dec 27 11:39:40 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114478/#review46182
-----------------------------------------------------------

Ship it!


As per discussion on kde-frameworks list.  I'll have a look at adding some magic to provide more helpful error messages (than "kshareddatacache.h not found") later.

- Alex Merry


On Dec. 15, 2013, 4:15 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114478/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2013, 4:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Since
> #define KImageCache KSharedPixmapCacheMixin<KSharedDataCache>
> I think it is only fair that kimagecache.h includes kshareddatacache.h otherwise a 
> #include <kimagecache.h>
> is not enough to use it.
> 
> 
> Diffs
> -----
> 
>   tier1/kguiaddons/src/util/kimagecache.h 682aa66 
> 
> Diff: https://git.reviewboard.kde.org/r/114478/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131227/dba44e37/attachment.html>


More information about the Kde-frameworks-devel mailing list