Macro naming

[Alex Merry]

On 23/12/13 01:42, Alex Merry wrote:
> On 23/12/13 01:27, Aleix Pol wrote:
>> On Mon, Dec 23, 2013 at 1:17 AM, Alex Merry <kde at randomguy3.me.uk
>> <mailto:kde at randomguy3.me.uk>> wrote:
>>
>>     Currently, we are not consistent about CMake macro naming in the
>>     frameworks.  KAuth, for example, has kauth_install_actions, while
>>     kdesignerplugin has kf5designerplugin_add_widget_files.
>>
>>     How do we want our macros prefixed?
>>
>> I would say that we want <modulename>_<macroname>. It's what we have in
>> most places I'd say. I don't think it's a good idea using kf5* since it
>> doesn't explain where it comes from.
> 
> The counterargument is that after doing
> find_package(KF5DesignerPlugin)
> you would generally expect any macros it provides to be prefixed with
> kf5designerplugin or some prefix or simple variant of it (like kf5 or
> kf5_designer_plugin).

Oh, and the versioning that we get from a kf5 prefix could prove to be
useful when we transition to KF6.

Alex