[PATCH] Fail early if libsm is not installed

Aurélien Gâteau agateau at kde.org
Thu Dec 19 17:10:11 UTC 2013


Hi,

Attached patch causes cmake to fail early if libsm is not installed, rather 
than waiting until we try to build code using it.

This patch also removes buggy calls to set_package_properties(). I found
out calling set_package_properties() with something which is not a
package as the first argument is currently silently ignored. Note that
this means the TYPE argument is ignored as well, so marking something as
REQUIRED has no effect.

As a result I put together a poor-man feature_summary() implementation
at the end of the CMakeLists.txt for X11 components. It's a bit overkill
for the needs of kde4support, but can be duplicated or factorized
later.

Aurélien
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fail-early-if-libsm-is-not-installed.patch
Type: text/x-patch
Size: 2618 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131219/e52aacb7/attachment.patch>


More information about the Kde-frameworks-devel mailing list