Review Request 114521: Rename DNSSD to KDNSSD

Aurélien Gâteau agateau at kde.org
Tue Dec 17 18:12:02 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114521/
-----------------------------------------------------------

(Updated Dec. 17, 2013, 7:11 p.m.)


Review request for KDE Frameworks.


Changes
-------

Fixed issues reported by Christophe.


Repository: kdelibs


Description
-------

Similar to the rename of the itemmodels framework to kitemmodels. The mdns part of the code was actually broken, and has been so for quite some time now. Might be worth evaluating whether we want to drop it to simplify maintenance (would have the nice side effect of making KDNSSD a tier1 framework).

Since the DBus name has changed, a fix is needed in kde-runtime[frameworks]. Will do so when this patch is in.


Diffs (updated)
-----

  superbuild/CMakeLists.txt 14b6904 
  tier2/CMakeLists.txt aecb4c1 
  tier2/dnssd/CMakeLists.txt eafc94b 
  tier2/dnssd/COPYING.LIB  
  tier2/dnssd/ConfigureChecks.cmake  
  tier2/dnssd/KF5DNSSDConfig.cmake.in  
  tier2/dnssd/Mainpage.dox 1686164 
  tier2/dnssd/PACKAGERS  
  tier2/dnssd/cmake/FindAvahi.cmake  
  tier2/dnssd/cmake/FindDNSSD.cmake  
  tier2/dnssd/config-dnssd.h.cmake  
  tier2/dnssd/src/CMakeLists.txt 301f452 
  tier2/dnssd/src/avahi-domainbrowser.cpp 8690671 
  tier2/dnssd/src/avahi-domainbrowser_p.h 1bf895c 
  tier2/dnssd/src/avahi-publicservice.cpp b3306f7 
  tier2/dnssd/src/avahi-publicservice_p.h aa4efbd 
  tier2/dnssd/src/avahi-remoteservice.cpp f039054 
  tier2/dnssd/src/avahi-remoteservice_p.h 0b25d60 
  tier2/dnssd/src/avahi-servicebrowser.cpp a2951ed 
  tier2/dnssd/src/avahi-servicebrowser_p.h 2611b26 
  tier2/dnssd/src/avahi-servicetypebrowser.cpp a694dd0 
  tier2/dnssd/src/avahi-servicetypebrowser_p.h 97cd50d 
  tier2/dnssd/src/avahi_entrygroup_interface.h  
  tier2/dnssd/src/avahi_entrygroup_interface.cpp  
  tier2/dnssd/src/avahi_server_interface.h f6955b1 
  tier2/dnssd/src/avahi_server_interface.cpp 7a6fa92 
  tier2/dnssd/src/avahi_serviceresolver_interface.h  
  tier2/dnssd/src/avahi_serviceresolver_interface.cpp  
  tier2/dnssd/src/domainbrowser.h 901a936 
  tier2/dnssd/src/domainmodel.h b7cfbe5 
  tier2/dnssd/src/domainmodel.cpp 1bea715 
  tier2/dnssd/src/dummy-domainbrowser.cpp a41bb2e 
  tier2/dnssd/src/dummy-publicservice.cpp d3135a4 
  tier2/dnssd/src/dummy-remoteservice.cpp 22eb623 
  tier2/dnssd/src/dummy-servicebrowser.cpp 260c1ff 
  tier2/dnssd/src/dummy-servicetypebrowser.cpp 18895cb 
  tier2/dnssd/src/kcm_kdnssd.kcfg  
  tier2/dnssd/src/mdnsd-domainbrowser.cpp c3c2032 
  tier2/dnssd/src/mdnsd-domainbrowser_p.h f7e1754 
  tier2/dnssd/src/mdnsd-publicservice.cpp 96f8db2 
  tier2/dnssd/src/mdnsd-remoteservice.cpp 3efaead 
  tier2/dnssd/src/mdnsd-responder.h b944cce 
  tier2/dnssd/src/mdnsd-responder.cpp 9c0bc45 
  tier2/dnssd/src/mdnsd-sdevent.h d20b0de 
  tier2/dnssd/src/mdnsd-servicebrowser.cpp a17694a 
  tier2/dnssd/src/mdnsd-servicebrowser_p.h 9d31c3a 
  tier2/dnssd/src/mdnsd-servicetypebrowser.cpp 2ac3f7f 
  tier2/dnssd/src/mdnsd-servicetypebrowser_p.h 9289588 
  tier2/dnssd/src/org.freedesktop.Avahi.DomainBrowser.xml  
  tier2/dnssd/src/org.freedesktop.Avahi.ServiceBrowser.xml  
  tier2/dnssd/src/org.freedesktop.Avahi.ServiceTypeBrowser.xml  
  tier2/dnssd/src/publicservice.h 6232f1b 
  tier2/dnssd/src/remoteservice.h 35edac8 
  tier2/dnssd/src/servicebase.h 3c487b0 
  tier2/dnssd/src/servicebase.cpp 9ddfdf5 
  tier2/dnssd/src/servicebase_p.h 066c35e 
  tier2/dnssd/src/servicebrowser.h 0a28e42 
  tier2/dnssd/src/servicemodel.h 4812831 
  tier2/dnssd/src/servicemodel.cpp f3de566 
  tier2/dnssd/src/servicetypebrowser.h b5a2452 
  tier2/dnssd/src/settings.kcfgc 01a31f0 
  tier4/kde4support/src/includes/CMakeLists.txt 710cfa9 
  tier4/kde4support/src/includes/DNSSD/Configuration afafd3d 
  tier4/kde4support/src/includes/DNSSD/DomainBrowser f2b9a9a 
  tier4/kde4support/src/includes/DNSSD/DomainModel 63d1a21 
  tier4/kde4support/src/includes/DNSSD/PublicService 4f665f1 
  tier4/kde4support/src/includes/DNSSD/RemoteService 1e0dc06 
  tier4/kde4support/src/includes/DNSSD/ServiceBase dc40c19 
  tier4/kde4support/src/includes/DNSSD/ServiceBrowser 221e9e9 
  tier4/kde4support/src/includes/DNSSD/ServiceModel cd07f94 
  tier4/kde4support/src/includes/DNSSD/ServiceTypeBrowser 03e384f 
  tier4/kde4support/src/includes/KDNSSD/Configuration PRE-CREATION 
  tier4/kde4support/src/includes/KDNSSD/DomainBrowser PRE-CREATION 
  tier4/kde4support/src/includes/KDNSSD/DomainModel PRE-CREATION 
  tier4/kde4support/src/includes/KDNSSD/PublicService PRE-CREATION 
  tier4/kde4support/src/includes/KDNSSD/RemoteService PRE-CREATION 
  tier4/kde4support/src/includes/KDNSSD/ServiceBase PRE-CREATION 
  tier4/kde4support/src/includes/KDNSSD/ServiceBrowser PRE-CREATION 
  tier4/kde4support/src/includes/KDNSSD/ServiceModel PRE-CREATION 
  tier4/kde4support/src/includes/KDNSSD/ServiceTypeBrowser PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/114521/diff/


Testing
-------

Built kdelibs once with Avahi and once with mdns.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131217/b16c821c/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list