Review Request 114518: Rename the itemmodels frameworks to kitemmodels

[Christophe Giboudeaux]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114518/#review45870
-----------------------------------------------------------


tier4/kde4support/KF5KDE4SupportConfig.cmake.in:60 also need a change


tier1/itemmodels/autotests/CMakeLists.txt
<http://git.reviewboard.kde.org/r/114518/#comment32740>

    you didn't rename the macro



tier1/itemmodels/CMakeLists.txt
<http://git.reviewboard.kde.org/r/114518/#comment32741>

    project(KItemModels)


- Christophe Giboudeaux


On Dec. 17, 2013, 3:03 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114518/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2013, 3:03 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Rename the itemmodels frameworks to kitemmodels, as "itemmodels" is considered too generic.
> 
> 
> Diffs
> -----
> 
>   KDE5PORTING.html a727079 
>   superbuild/CMakeLists.txt 146d34c 
>   tier1/CMakeLists.txt b23e8ea 
>   tier1/itemmodels/CMakeLists.txt 60105fc 
>   tier1/itemmodels/COPYING.LIB  
>   tier1/itemmodels/KF5ItemModelsConfig.cmake.in  
>   tier1/itemmodels/Mainpage.dox  
>   tier1/itemmodels/autotests/CMakeLists.txt 8beb0bf 
>   tier1/itemmodels/autotests/bihash/CMakeLists.txt  
>   tier1/itemmodels/autotests/bihash/aggregrator.xls  
>   tier1/itemmodels/autotests/bihash/benchmarker.py  
>   tier1/itemmodels/autotests/bihash/benchmarks.cpp  
>   tier1/itemmodels/autotests/bihash/functionalitytest.cpp  
>   tier1/itemmodels/autotests/bihash/script.py  
>   tier1/itemmodels/autotests/kdescendantentitiesproxymodeltest.cpp  
>   tier1/itemmodels/autotests/kdescendantsproxymodeltest.cpp  
>   tier1/itemmodels/autotests/klinkitemselectionmodeltest.h  
>   tier1/itemmodels/autotests/klinkitemselectionmodeltest.cpp  
>   tier1/itemmodels/autotests/kselectionproxymodeltest.cpp  
>   tier1/itemmodels/autotests/kselectionproxymodeltestsuite.h  
>   tier1/itemmodels/autotests/kselectionproxymodeltestsuite.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/CMakeLists.txt  
>   tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbdirectionwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbdirectionwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbnavigationwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbnavigationwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbswidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbswidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/checkablewidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/checkablewidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/descendantpmwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/descendantpmwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/kidentityproxymodelwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/kidentityproxymodelwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/kreparentingproxymodel.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/kreparentingproxymodel.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/lessthanwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/lessthanwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/main.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/mainwindow.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/mainwindow.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/matchcheckingwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/matchcheckingwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/modelcommanderwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/modelcommanderwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/proxyitemselectionwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/proxyitemselectionwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/proxymodeltestwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/proxymodeltestwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/recursivefilterpmwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/recursivefilterpmwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/reparenting1.png  
>   tier1/itemmodels/autotests/proxymodeltestapp/reparenting2.png  
>   tier1/itemmodels/autotests/proxymodeltestapp/reparenting3.png  
>   tier1/itemmodels/autotests/proxymodeltestapp/reparentingpmwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/reparentingpmwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/scriptablereparentingwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/scriptablereparentingwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/selectionpmwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/selectionpmwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/statesaverwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/statesaverwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestsuite/CMakeLists.txt  
>   tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreemodel.h  
>   tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreemodel.cpp  
>   tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreewidget.h  
>   tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreewidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestsuite/eventlogger.qrc  
>   tier1/itemmodels/autotests/proxymodeltestsuite/eventloggerregister.h  
>   tier1/itemmodels/autotests/proxymodeltestsuite/eventloggerregister.cpp  
>   tier1/itemmodels/autotests/proxymodeltestsuite/grantlee_paths.h.cmake  
>   tier1/itemmodels/autotests/proxymodeltestsuite/indexfinder.h  
>   tier1/itemmodels/autotests/proxymodeltestsuite/modelcommander.h  
>   tier1/itemmodels/autotests/proxymodeltestsuite/modelcommander.cpp  
>   tier1/itemmodels/autotests/proxymodeltestsuite/modeldumper.h  
>   tier1/itemmodels/autotests/proxymodeltestsuite/modeldumper.cpp  
>   tier1/itemmodels/autotests/proxymodeltestsuite/modeleventlogger.h  
>   tier1/itemmodels/autotests/proxymodeltestsuite/modeleventlogger.cpp  
>   tier1/itemmodels/autotests/proxymodeltestsuite/modelselector.h  
>   tier1/itemmodels/autotests/proxymodeltestsuite/modelselector.cpp  
>   tier1/itemmodels/autotests/proxymodeltestsuite/modelspy.h  
>   tier1/itemmodels/autotests/proxymodeltestsuite/modelspy.cpp  
>   tier1/itemmodels/autotests/proxymodeltestsuite/modeltest.h  
>   tier1/itemmodels/autotests/proxymodeltestsuite/modeltest.cpp  
>   tier1/itemmodels/autotests/proxymodeltestsuite/persistentchangelist.h  
>   tier1/itemmodels/autotests/proxymodeltestsuite/proxymodeltest.h  
>   tier1/itemmodels/autotests/proxymodeltestsuite/proxymodeltest.cpp  
>   tier1/itemmodels/autotests/proxymodeltestsuite/templates/datachanged.cpp  
>   tier1/itemmodels/autotests/proxymodeltestsuite/templates/init.cpp  
>   tier1/itemmodels/autotests/proxymodeltestsuite/templates/layoutchanged.cpp  
>   tier1/itemmodels/autotests/proxymodeltestsuite/templates/main.cpp  
>   tier1/itemmodels/autotests/proxymodeltestsuite/templates/modelreset.cpp  
>   tier1/itemmodels/autotests/proxymodeltestsuite/templates/rowsinserted.cpp  
>   tier1/itemmodels/autotests/proxymodeltestsuite/templates/rowsremoved.cpp  
>   tier1/itemmodels/autotests/testmodelqueuedconnections.cpp  
>   tier1/itemmodels/dox/descendantentitiesproxymodel-colfilter.png  
>   tier1/itemmodels/dox/descendantentitiesproxymodel-withansecnames.png  
>   tier1/itemmodels/dox/descendantentitiesproxymodel.png  
>   tier1/itemmodels/dox/entitytreemodel-collections.png  
>   tier1/itemmodels/dox/entitytreemodel-showroot.png  
>   tier1/itemmodels/dox/entitytreemodel-showrootwithname.png  
>   tier1/itemmodels/dox/entitytreemodel.png  
>   tier1/itemmodels/dox/kbreadcrumbselectionmodel.png  
>   tier1/itemmodels/dox/kcheckableproxymodel.png  
>   tier1/itemmodels/dox/kproxyitemselectionmodel-complex.png  
>   tier1/itemmodels/dox/kproxyitemselectionmodel-error.png  
>   tier1/itemmodels/dox/kproxyitemselectionmodel-simple.png  
>   tier1/itemmodels/dox/kproxyitemselectionmodel-solution.png  
>   tier1/itemmodels/dox/kselectionproxymodel-testapp.png  
>   tier1/itemmodels/dox/mailmodelapp.png  
>   tier1/itemmodels/dox/selectionproxymodel-ordered.png  
>   tier1/itemmodels/dox/selectionproxymodelmultipleselection-withdescendant.png  
>   tier1/itemmodels/dox/selectionproxymodelmultipleselection.png  
>   tier1/itemmodels/dox/selectionproxymodelsimpleselection.png  
>   tier1/itemmodels/dox/treeandlistapp.png  
>   tier1/itemmodels/dox/treeandlistappwithdesclist.png  
>   tier1/itemmodels/src/CMakeLists.txt 7e4932b 
>   tier1/itemmodels/src/kbihash_p.h  
>   tier1/itemmodels/src/kbreadcrumbselectionmodel.h 8bf73e9 
>   tier1/itemmodels/src/kbreadcrumbselectionmodel.cpp  
>   tier1/itemmodels/src/kcheckableproxymodel.h 3dcbd00 
>   tier1/itemmodels/src/kcheckableproxymodel.cpp  
>   tier1/itemmodels/src/kdescendantsproxymodel.h 268a982 
>   tier1/itemmodels/src/kdescendantsproxymodel.cpp  
>   tier1/itemmodels/src/klinkitemselectionmodel.h bcb2717 
>   tier1/itemmodels/src/klinkitemselectionmodel.cpp  
>   tier1/itemmodels/src/kmodelindexproxymapper.h 72ddb80 
>   tier1/itemmodels/src/kmodelindexproxymapper.cpp  
>   tier1/itemmodels/src/krecursivefilterproxymodel.h f9dc3bf 
>   tier1/itemmodels/src/krecursivefilterproxymodel.cpp  
>   tier1/itemmodels/src/kselectionproxymodel.h 0ad752f 
>   tier1/itemmodels/src/kselectionproxymodel.cpp  
>   tier1/itemmodels/src/kvoidpointerfactory_p.h  
> 
> Diff: http://git.reviewboard.kde.org/r/114518/diff/
> 
> 
> Testing
> -------
> 
> built kdelibs. I expect some breakage downstream though.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131217/eb99b3b5/attachment-0001.html>