Review Request 114496: Rename kdewidgets to kf5designerplugin

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114496/#review45813
-----------------------------------------------------------


Shouldn't KDEWidgetsMacros.cmake be renamed too?


tier3/CMakeLists.txt
<http://git.reviewboard.kde.org/r/114496/#comment32728>

    Now that I see it, it makes me think it could be named kdesignerplugin, no need to repeat the kf5 here imo.


- Kevin Ottens


On Dec. 16, 2013, 1:03 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114496/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2013, 1:03 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Rename kdewidgets to kf5designerplugin
> 
> This includes renaming makekdewidgets to kgendesignerplugin.
> 
> 
> Just throwing this at reviewboard before I dash for a train.
> 
> 
> Diffs
> -----
> 
>   tier3/CMakeLists.txt 374396b3909d5a71dff6d891249ab33194a45522 
>   tier3/kdewidgets/CMakeLists.txt 87c3d5484dfb86018cdd203807588ea6ebd6ac31 
>   tier3/kdewidgets/KDEWidgetsConfig.cmake d38c875c67a3073e7634bd6f873a38411127b759 
>   tier3/kdewidgets/KDEWidgetsMacros.cmake 92d2960a7dfe1645d7c75e3dc6690d78b50706d8 
>   tier3/kdewidgets/Mainpage.dox 85da237c9d4367a37b9b0750565d42e1e73d1ba4 
>   tier3/kdewidgets/docs/CMakeLists.txt 2b38f53f807c528fdcd6ea128567f6087bd8c673 
>   tier3/kdewidgets/docs/makekdewidgets/CMakeLists.txt c283b926f542402d80e22cc42406b119e400a05f 
>   tier3/kdewidgets/docs/makekdewidgets/man-makekdewidgets.1.docbook cab0c5b51f2bb5be29960f43fe6fb940fffb5402 
>   tier3/kdewidgets/src/AUTHORS  
>   tier3/kdewidgets/src/CMakeLists.txt e8626c84227a2ccd0459c5732a51e9ecea49f699 
>   tier3/kdewidgets/src/README  
>   tier3/kdewidgets/src/classpreviews.h  
>   tier3/kdewidgets/src/classpreviews.cpp  
>   tier3/kdewidgets/src/kde.widgets 7bcc669d14ed40da6217d09296e25d60a59413b7 
>   tier3/kdewidgets/src/kdewebkit.widgets  
>   tier3/kdewidgets/src/kdewebkitwidgets.qrc  
>   tier3/kdewidgets/src/kdewidgets.qrc  
>   tier3/kdewidgets/src/makekdewidgets.cpp d20e49956a939a06fe3bc2280d57c5c6d31fe24c 
>   tier3/kdewidgets/src/pics/CMakeLists.txt 688224a6a1ca9f68b7e7f918fa6b8aee3dbe6180 
>   tier3/kdewidgets/src/pics/k3iconview.png  
>   tier3/kdewidgets/src/pics/k3listview.png  
>   tier3/kdewidgets/src/pics/kactionselector.png  
>   tier3/kdewidgets/src/pics/kactivelabel.png  
>   tier3/kdewidgets/src/pics/kcharselect.png  
>   tier3/kdewidgets/src/pics/kcmodule.png  
>   tier3/kdewidgets/src/pics/kcolorbutton.png  
>   tier3/kdewidgets/src/pics/kcolorcombo.png  
>   tier3/kdewidgets/src/pics/kcombobox.png  
>   tier3/kdewidgets/src/pics/kdatepicker.png  
>   tier3/kdewidgets/src/pics/kdatetable.png  
>   tier3/kdewidgets/src/pics/kdualcolorbutton.png  
>   tier3/kdewidgets/src/pics/keditlistwidget.png  
>   tier3/kdewidgets/src/pics/kfontcombo.png  
>   tier3/kdewidgets/src/pics/kfontrequester.png  
>   tier3/kdewidgets/src/pics/kgradientselector.png  
>   tier3/kdewidgets/src/pics/khistorycombo.png  
>   tier3/kdewidgets/src/pics/khsselector.png  
>   tier3/kdewidgets/src/pics/kiconbutton.png  
>   tier3/kdewidgets/src/pics/kkeybutton.png  
>   tier3/kdewidgets/src/pics/kled.png  
>   tier3/kdewidgets/src/pics/klineedit.png  
>   tier3/kdewidgets/src/pics/klistbox.png  
>   tier3/kdewidgets/src/pics/kpalettetable.png  
>   tier3/kdewidgets/src/pics/kpasswordedit.png  
>   tier3/kdewidgets/src/pics/kruler.png  
>   tier3/kdewidgets/src/pics/ksqueezedtextlabel.png  
>   tier3/kdewidgets/src/pics/ktextedit.png  
>   tier3/kdewidgets/src/pics/kurlcomborequester.png  
>   tier3/kdewidgets/src/pics/kurllabel.png  
>   tier3/kdewidgets/src/pics/kurlrequester.png  
>   tier3/kdewidgets/tests/CMakeLists.txt  
>   tier3/kdewidgets/tests/README 9dd2132fa7c3601ae04f243a5996aa809b42f7bf 
>   tier3/kdewidgets/tests/sums  
>   tier3/kdewidgets/tests/test.widgets  
>   tier3/kf5designerplugin/KF5DesignerPluginConfig.cmake PRE-CREATION 
>   tier3/kf5designerplugin/Mainpage.dox PRE-CREATION 
>   tier3/kf5designerplugin/docs/CMakeLists.txt PRE-CREATION 
>   tier3/kf5designerplugin/docs/kgendesignerplugin/CMakeLists.txt PRE-CREATION 
>   tier3/kf5designerplugin/docs/kgendesignerplugin/man-kgendesignerplugin.1.docbook PRE-CREATION 
>   tier3/kf5designerplugin/src/CMakeLists.txt PRE-CREATION 
>   tier3/kf5designerplugin/tests/README PRE-CREATION 
>   tier4/kde4support/CMakeLists.txt ccbffd24ede13d5ae6d8386a4aac1853018fcc97 
>   tier4/kde4support/src/CMakeLists.txt 467e8378e555139774924f053b477050ebba9f5c 
>   tier4/kde4support/src/KDEUIMacros.cmake 31a180c1aab14f22e6a157e8aabfa901db15081a 
>   tier4/kde4support/src/kdedeprecated.widgets 604358ac69ba8a8cfbdd8b41a796405fdddebd12 
>   tier4/kde4support/src/pics/CMakeLists.txt c0e1c2064af67e9ad90d8f5e8a9c892208c6cda0 
> 
> Diff: http://git.reviewboard.kde.org/r/114496/diff/
> 
> 
> Testing
> -------
> 
> CMake runs, nothing else tested.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131216/f5295404/attachment-0001.html>