Review Request 114501: Rename KDE4_ENABLE_EXCEPTIONS to KDE_ENABLE_EXCEPTIONS

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114501/
-----------------------------------------------------------

(Updated Dec. 16, 2013, 6:10 p.m.)


Review request for Build System and KDE Frameworks.


Changes
-------

Add link to kdelibs patch


Repository: extra-cmake-modules


Description (updated)
-------

Rename KDE4_ENABLE_EXCEPTIONS to KDE_ENABLE_EXCEPTIONS. One less KDE4 reference. I have a matching patch for kdelibs once this goes in. When the kdelibs patch is in, the temporary definition of KDE4_ENABLE_EXCEPTIONS can be removed.

Would be good to also factorize the definition and decide once and for all if it should include -UQT_NO_EXCEPTIONS, but that's for another review.

kdelibs patch: https://git.reviewboard.kde.org/r/114502/


Diffs
-----

  kde-modules/KDECompilerSettings.cmake 6dafc5f 

Diff: http://git.reviewboard.kde.org/r/114501/diff/


Testing
-------

kdelibs build. Checked with `make VERBOSE=1` the exception flags are still correctly passed.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131216/1b4d61e5/attachment.html>