Review Request 114478: Add kshareddatacache.h include
Kevin Ottens
ervin at kde.org
Sun Dec 15 21:22:06 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114478/#review45732
-----------------------------------------------------------
It is in fact intended that way as kguiaddons isn't supposed to include stuff coming from kcoreaddons (yeah I know it's slightly convoluted in that particular case).
- Kevin Ottens
On Dec. 15, 2013, 4:15 p.m., Albert Astals Cid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114478/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2013, 4:15 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Since
> #define KImageCache KSharedPixmapCacheMixin<KSharedDataCache>
> I think it is only fair that kimagecache.h includes kshareddatacache.h otherwise a
> #include <kimagecache.h>
> is not enough to use it.
>
>
> Diffs
> -----
>
> tier1/kguiaddons/src/util/kimagecache.h 682aa66
>
> Diff: http://git.reviewboard.kde.org/r/114478/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Albert Astals Cid
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131215/c9e4a224/attachment.html>
More information about the Kde-frameworks-devel
mailing list