Review Request 114447: Split Frameworks only definitions to a new file

Aleix Pol Gonzalez aleixpol at kde.org
Sat Dec 14 15:40:22 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114447/#review45683
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Dec. 14, 2013, 3:29 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114447/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2013, 3:29 p.m.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Don't force this extra "correctness" Qt flags on the rest of the people, let them decide by themselves.
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDECompilerSettings.cmake 5f2da5e 
>   kde-modules/KDEFrameworkCompilerSettings.cmake PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/114447/diff/
> 
> 
> Testing
> -------
> 
> Installed, change kdelibs to use the new file instead of the old, all was the same.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131214/86d2bc72/attachment.html>


More information about the Kde-frameworks-devel mailing list