Review Request 112463: Port SMB kioslave to KF5/Qt5

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/
-----------------------------------------------------------

(Updated Dec. 10, 2013, 6:51 p.m.)


Review request for KDE Runtime and KDE Frameworks.


Changes
-------

Updated according to feedback.


Repository: kde-runtime


Description
-------

This is the initial port! I added two TODO lines in the diff for parts where i'm not sure if I've ported them correctly.
Also, i needed a change in FindSamba.cmake to even get the samba detection working. That reviewrequest is waiting here: https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use samba 3.x

Once i know that this is actually working then i will comment some qDebug lines.


Diffs (updated)
-----

  kioslave/CMakeLists.txt fc594e4 
  kioslave/smb/CMakeLists.txt a3a2265 
  kioslave/smb/kio_smb.h c2229ab 
  kioslave/smb/kio_smb.cpp 2c2523a 
  kioslave/smb/kio_smb_auth.cpp 4d236b4 
  kioslave/smb/kio_smb_browse.cpp 5253be9 
  kioslave/smb/kio_smb_dir.cpp ba80c86 
  kioslave/smb/kio_smb_file.cpp 206526a 
  kioslave/smb/kio_smb_internal.h 4b946c1 
  kioslave/smb/kio_smb_internal.cpp e943844 
  kioslave/smb/kio_smb_mount.cpp a5a7e8e 
  kioslave/smb/kio_smb_win.h f1dcb6f 
  kioslave/smb/kio_smb_win.cpp 14dd797 

Diff: http://git.reviewboard.kde.org/r/112463/diff/


Testing
-------

It compiles and gets loaded just fine. I tried testing this on an actual samba share, but i kept getting a 111 error (connection refused) from kio_smb so i'm hoping that is a local issue here. If someone else could try this out and verify that it's either working or broken.


Thanks,

Mark Gaiser

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131210/b2251749/attachment.html>