Review Request 112463: Port SMB kioslave to KF5/Qt5

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/#review45466
-----------------------------------------------------------



kioslave/smb/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112463/#comment32421>

    this should be:
    add_library(kio_smb MODULE {kio_smb_PART_SRCS})



kioslave/smb/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112463/#comment32422>

    also add_library.



kioslave/smb/kio_smb.h
<http://git.reviewboard.kde.org/r/112463/#comment32423>

    do you need klocale? it's deprecated.



kioslave/smb/kio_smb_auth.cpp
<http://git.reviewboard.kde.org/r/112463/#comment32424>

    AAAAAAAAA
    
    xD
    Maybe we can just remove this one?



kioslave/smb/kio_smb_internal.h
<http://git.reviewboard.kde.org/r/112463/#comment32426>

    it might be a good moment to remove this comment-



kioslave/smb/kio_smb_internal.cpp
<http://git.reviewboard.kde.org/r/112463/#comment32427>

    Does it really need QDir::separator()? It seems to me like everything should be '/'.


- Aleix Pol Gonzalez


On Dec. 5, 2013, 11:44 p.m., Mark Gaiser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112463/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2013, 11:44 p.m.)
> 
> 
> Review request for KDE Runtime and KDE Frameworks.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> This is the initial port! I added two TODO lines in the diff for parts where i'm not sure if I've ported them correctly.
> Also, i needed a change in FindSamba.cmake to even get the samba detection working. That reviewrequest is waiting here: https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use samba 3.x
> 
> Once i know that this is actually working then i will comment some qDebug lines.
> 
> 
> Diffs
> -----
> 
>   kioslave/CMakeLists.txt fc594e4 
>   kioslave/smb/CMakeLists.txt a3a2265 
>   kioslave/smb/kio_smb.h c2229ab 
>   kioslave/smb/kio_smb.cpp 2c2523a 
>   kioslave/smb/kio_smb_auth.cpp 4d236b4 
>   kioslave/smb/kio_smb_browse.cpp 5253be9 
>   kioslave/smb/kio_smb_dir.cpp ba80c86 
>   kioslave/smb/kio_smb_file.cpp 206526a 
>   kioslave/smb/kio_smb_internal.h 4b946c1 
>   kioslave/smb/kio_smb_internal.cpp e943844 
>   kioslave/smb/kio_smb_mount.cpp a5a7e8e 
>   kioslave/smb/kio_smb_win.h f1dcb6f 
>   kioslave/smb/kio_smb_win.cpp 14dd797 
> 
> Diff: http://git.reviewboard.kde.org/r/112463/diff/
> 
> 
> Testing
> -------
> 
> It compiles and gets loaded just fine. I tried testing this on an actual samba share, but i kept getting a 111 error (connection refused) from kio_smb so i'm hoping that is a local issue here. If someone else could try this out and verify that it's either working or broken.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131210/15ad2cf5/attachment-0001.html>