Review Request 114328: re-add customstyleelement suite to kstyle

Àlex Fiestas afiestas at kde.org
Sun Dec 8 00:05:52 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114328/#review45335
-----------------------------------------------------------

Ship it!


Code looks good, you are the master of QStyle if you think those methods are useful, please ship it!

- Àlex Fiestas


On Dec. 6, 2013, 2:43 p.m., Hugo Pereira Da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114328/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2013, 2:43 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> re-add customstyleelement suite to kstyle
> 
> 
> Diffs
> -----
> 
>   tier4/frameworkintegration/src/kstyle/kstyle.h 8a881f5 
>   tier4/frameworkintegration/src/kstyle/kstyle.cpp 27d407e 
> 
> Diff: http://git.reviewboard.kde.org/r/114328/diff/
> 
> 
> Testing
> -------
> 
> compiles, works, fix kde-workspace build
> also: will be used when moving oxygen from qcommonstyle back to kstyle (right now we have a fork of some of the said methods)
> 
> 
> Thanks,
> 
> Hugo Pereira Da Costa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131208/6849175e/attachment.html>


More information about the Kde-frameworks-devel mailing list