Review Request 114184: Remove everything in kstyle that is not about KDE integration

[David Faure]

On Friday 06 December 2013 10:00:08 Kevin Ottens wrote:
> On Thursday 05 December 2013 17:02:13 Hugo Pereira Da Costa wrote:
> > As a consequence: kde-workspace currently does not compile.
> > We can:
> > 1/ re-add the functionality inside kstyle (its a couple of static
> > functions basically)
> > 2/ use K4Style but that would make oxygen-decoration depend on KDE4Support
> > 3/ drop the functionality: but then: no shadows around drag and drop
> > icon for tabbed windows, because it looks ugly for styles that do not
> > support ARGB drag and drop icon
> > 4/ Anything else ? (suggestions welcome)
> > 
> > I'd vote for 1/ and volunteer to make the change if agreed.
> 
> Works for me. IMO you're the best placed to know what is really important in
> the old KStyle and what was useless stuff.

I agree. On the other hand, if it's static methods, they could also very well 
go into a different class. No technical difference, that other class can live 
in the same framework as far as I'm concerned, but the point is making it 
clear that this is unrelated to "using KStyle as a base class instead of 
QStyle". For proof, you say it's used in decoration stuff.

If that functionality had already been splitted out, it wouldn't have been cut 
with the rest.

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5