Review Request 114182: Add Kf5 prefix for libs, eg. libKf5Foo

Alex Merry kde at randomguy3.me.uk
Thu Dec 5 14:59:34 UTC 2013 


> On Dec. 4, 2013, 8:01 p.m., Kevin Ottens wrote:
> > Looks mostly good, but something looks wrong with the patch, I guess you moved the *Config.cmake.in files, but we see them simply deleted, as they got probably edited too (because of the target files) it'd be nice to get a more complete patch.
> 
> Alex Merry wrote:
>     In particular, you may want to use
>     `git diff --find-copies-harder frameworks`
>     to generate the diff file.
> 
> Martin Klapetek wrote:
>     I tried that, however the files are rather small and very similar, so it was even more confusing (as it showed several deleted files moved into one with similarity index ~55%...so I deemed it useless).

Huh.  What's puzzling, though, is that while the diff shows tier1/itemmodels/ItemModelsConfig.cmake.in as being deleted, it doesn't show tier1/itemmodels/KF5ItemModelsConfig.cmake.in as being added (and similarly for the other .cmake.in files).  Any idea why?


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114182/#review45137
-----------------------------------------------------------


On Nov. 29, 2013, 1:04 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114182/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2013, 1:04 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This is just one framework - KConfig - if this is the proper way to do this, I'll update this review with all frameworks updated to this.
> 
> 
> Diffs
> -----
> 
>   tier1/itemmodels/CMakeLists.txt d0be692 
>   tier1/itemmodels/ItemModelsConfig.cmake.in 4ac98f3 
>   tier1/itemmodels/autotests/CMakeLists.txt 03daf70 
>   tier1/itemmodels/autotests/proxymodeltestapp/CMakeLists.txt 525c9f3 
>   tier1/itemmodels/src/CMakeLists.txt 86b48cf 
>   tier1/itemviews/CMakeLists.txt 1bdadac 
>   tier1/itemviews/ItemViewsConfig.cmake.in 1956453 
>   tier1/itemviews/autotests/CMakeLists.txt 0219900 
>   tier1/itemviews/src/CMakeLists.txt bad773c 
>   tier1/itemviews/tests/CMakeLists.txt 4ddf5d8 
>   tier1/karchive/CMakeLists.txt f0d12ac 
>   tier1/karchive/KArchiveConfig.cmake.in 40fa614 
>   tier1/karchive/autotests/CMakeLists.txt a2cfabe 
>   tier1/karchive/examples/helloworld/CMakeLists.txt 2e90094 
>   tier1/karchive/examples/tarlocalfiles/CMakeLists.txt b855caf 
>   tier1/karchive/src/CMakeLists.txt 767140a 
>   tier1/karchive/tests/CMakeLists.txt d804cd2 
>   tier1/kcodecs/CMakeLists.txt a8217d0 
>   tier1/kcodecs/KCodecsConfig.cmake.in ea632ce 
>   tier1/kcodecs/autotests/CMakeLists.txt bf393f8 
>   tier1/kcodecs/src/CMakeLists.txt 152bc8e 
>   tier1/kconfig/CMakeLists.txt af91aa2 
>   tier1/kconfig/KConfigConfig.cmake.in 5d9d7eb 
>   tier1/kconfig/autotests/CMakeLists.txt cc2626b 
>   tier1/kconfig/autotests/kconfig_compiler/CMakeLists.txt 184ab17 
>   tier1/kconfig/src/core/CMakeLists.txt c8a4842 
>   tier1/kconfig/src/gui/CMakeLists.txt b677d03 
>   tier1/kconfig/src/kconf_update/CMakeLists.txt 69668bc 
>   tier1/kconfig/src/kconfig_compiler/CMakeLists.txt 19d86d4 
>   tier1/kcoreaddons/CMakeLists.txt 5d2b4a8 
>   tier1/kcoreaddons/KCoreAddonsConfig.cmake.in a53be5f 
>   tier1/kcoreaddons/autotests/CMakeLists.txt c804357 
>   tier1/kcoreaddons/src/lib/CMakeLists.txt 638525f 
>   tier1/kcoreaddons/tests/CMakeLists.txt c79d0ba 
>   tier1/kdbusaddons/CMakeLists.txt 78cc443 
>   tier1/kdbusaddons/KDBusAddonsConfig.cmake.in 27a6060 
>   tier1/kdbusaddons/autotests/CMakeLists.txt 92c9151 
>   tier1/kdbusaddons/src/CMakeLists.txt 71dc290 
>   tier1/kdbusaddons/tests/CMakeLists.txt 684fee3 
>   tier1/kguiaddons/CMakeLists.txt b3f378d 
>   tier1/kguiaddons/KGuiAddonsConfig.cmake.in 83e4c91 
>   tier1/kguiaddons/autotests/CMakeLists.txt 2e4a6bb 
>   tier1/kguiaddons/src/CMakeLists.txt ca94f4b 
>   tier1/kguiaddons/tests/CMakeLists.txt 754b460 
>   tier1/kidletime/CMakeLists.txt 61ba25b 
>   tier1/kidletime/KIdleTimeConfig.cmake.in ace9e8a 
>   tier1/kidletime/examples/CMakeLists.txt c88a6c3 
>   tier1/kidletime/src/CMakeLists.txt 44a1f3f 
>   tier1/kjs/CMakeLists.txt ab27a14 
>   tier1/kjs/KJSConfig.cmake.in 8c4ff9e 
>   tier1/kjs/autotests/CMakeLists.txt 206c17a 
>   tier1/kjs/src/kjs/CMakeLists.txt b63d92f 
>   tier1/kjs/src/kjs/api/CMakeLists.txt dadf39c 
>   tier1/kjs/tests/CMakeLists.txt 9388a70 
>   tier1/kplotting/CMakeLists.txt f8e53ff 
>   tier1/kplotting/KPlottingConfig.cmake.in 42d4fae 
>   tier1/kplotting/autotests/CMakeLists.txt cc03ea4 
>   tier1/kplotting/examples/CMakeLists.txt 7c8ab7e 
>   tier1/kplotting/src/CMakeLists.txt 59e7d09 
>   tier1/kwidgetsaddons/CMakeLists.txt 570630b 
>   tier1/kwidgetsaddons/KWidgetsAddonsConfig.cmake.in 98dbc46 
>   tier1/kwidgetsaddons/autotests/CMakeLists.txt 1f6b69f 
>   tier1/kwidgetsaddons/src/CMakeLists.txt 0333f3a 
>   tier1/kwidgetsaddons/tests/CMakeLists.txt 129504b 
>   tier1/kwindowsystem/CMakeLists.txt cebdf49 
>   tier1/kwindowsystem/KWindowSystemConfig.cmake.in 49308aa 
>   tier1/kwindowsystem/autotests/CMakeLists.txt 92d4868 
>   tier1/kwindowsystem/src/CMakeLists.txt f6e27ee 
>   tier1/kwindowsystem/tests/CMakeLists.txt fbf3d26 
>   tier1/solid/CMakeLists.txt 6676410 
>   tier1/solid/SolidConfig.cmake.in 16637e9 
>   tier1/solid/autotests/CMakeLists.txt 8c46a1a 
>   tier1/solid/src/imports/CMakeLists.txt ac91736 
>   tier1/solid/src/solid/CMakeLists.txt 024c7fa 
>   tier1/solid/tests/CMakeLists.txt 6bcf3cf 
>   tier1/sonnet/CMakeLists.txt bad6191 
>   tier1/sonnet/SonnetConfig.cmake.in 13dcfe4 
>   tier1/sonnet/autotests/CMakeLists.txt c979842 
>   tier1/sonnet/src/core/CMakeLists.txt 7aa41c0 
>   tier1/sonnet/src/plugins/aspell/CMakeLists.txt e2d78b8 
>   tier1/sonnet/src/plugins/enchant/CMakeLists.txt 9270833 
>   tier1/sonnet/src/plugins/hspell/CMakeLists.txt b846ed4 
>   tier1/sonnet/src/plugins/hunspell/CMakeLists.txt 0730284 
>   tier1/sonnet/src/ui/CMakeLists.txt 2e2ef16 
>   tier1/sonnet/tests/CMakeLists.txt 71d0ad6 
>   tier1/threadweaver/CMakeLists.txt 61c2587 
>   tier1/threadweaver/ThreadWeaverConfig.cmake.in bc116f0c 
>   tier1/threadweaver/autotests/CMakeLists.txt 9ae5b1d 
>   tier1/threadweaver/benchmarks/CMakeLists.txt 07f7875 
>   tier1/threadweaver/src/Weaver/CMakeLists.txt d003e9f 
>   tier1/threadweaver/src/WeaverGui/CMakeLists.txt 4c4e1b2 
> 
> Diff: http://git.reviewboard.kde.org/r/114182/diff/
> 
> 
> Testing
> -------
> 
> Builds.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131205/97bba51e/attachment-0001.html>

More information about the Kde-frameworks-devel mailing list