Review Request 114200: Add include for klocalizedstring in klocale.h

Commit Hook null at kde.org
Thu Dec 5 10:35:31 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114200/#review45170
-----------------------------------------------------------


This review has been submitted with commit 4af8bf137c7a9d194ce0a94fab660d3913ebc9ed by Martin Gräßlin to branch frameworks.

- Commit Hook


On Nov. 29, 2013, 12:22 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114200/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2013, 12:22 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> One of the most often porting error I get is the lack of the KLocalizedString include. In KDE4 times this was through klocale. So most files have an include to klocale, but it is not used at all.
> 
> By adding this include to klocale.h we can significantly decrease the initial "get-it-compile-pain".
> 
> 
> Diffs
> -----
> 
>   tier4/kde4support/src/kdecore/klocale.h 1c446fe 
> 
> Diff: http://git.reviewboard.kde.org/r/114200/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131205/e249ca13/attachment.html>


More information about the Kde-frameworks-devel mailing list