Review Request 114256: Make QFileDialog use KFileWidget from the KDE PlatformTheme

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114256/
-----------------------------------------------------------

(Updated Dec. 4, 2013, 6:09 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
-------

Since I'd say it's the most important dialog, I decided to adopt it right away.

Instead of moving KFileDialog or anything, I chose to create a new dialog that just contains a KFileWidget, which is what I understand what we want in a last instance.

Everything is deeply undocumented, so if anybody has a clue about QPlatformTheme, it would be interesting if s/he could take a look.


Diffs
-----

  tier4/frameworkintegration/tests/CMakeLists.txt 4ed65f8 
  tier4/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp 010eed4 
  tier4/frameworkintegration/src/platformtheme/kdeplatformtheme.h 69f1f44 
  tier4/frameworkintegration/src/platformtheme/kdeplatformfiledialoghelper.cpp PRE-CREATION 
  tier4/frameworkintegration/src/platformtheme/kdeplatformfiledialoghelper.h PRE-CREATION 
  tier4/frameworkintegration/src/platformtheme/CMakeLists.txt 5d95c8a 
  tier4/frameworkintegration/autotests/CMakeLists.txt f126859 
  tier4/frameworkintegration/CMakeLists.txt 02b3563 
  tier4/frameworkintegration/tests/qfiledialogtest.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/114256/diff/


Testing
-------

Created a test app that instantiates a QFileDialog, used a QFileDialog from systemsettings.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131204/db9ec32c/attachment.html>