Review Request 114263: Port share dataengine to KF5

[Andrea Scarpino]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114263/
-----------------------------------------------------------

(Updated Dec. 3, 2013, 10:56 a.m.)


Review request for KDE Frameworks and Plasma.


Changes
-------

Diff updated.


Repository: kde-workspace


Description
-------

= subject

I also re-factored setUrl(QString&) to setUrl(QUrl&).


Diffs (updated)
-----

  plasma/generic/dataengines/CMakeLists.txt 3e94325 
  plasma/generic/dataengines/share/CMakeLists.txt 9c8f779 
  plasma/generic/dataengines/share/data/CMakeLists.txt PRE-CREATION 
  plasma/generic/dataengines/share/plugin_share_package.cpp ac81a31 
  plasma/generic/dataengines/share/share_package.h 00df488 
  plasma/generic/dataengines/share/share_package.cpp a31c6c5 
  plasma/generic/dataengines/share/shareengine.h 4cedc86 
  plasma/generic/dataengines/share/shareengine.cpp 86c308f 
  plasma/generic/dataengines/share/shareprovider.h d17ddd9 
  plasma/generic/dataengines/share/shareprovider.cpp fc528f8 
  plasma/generic/dataengines/share/shareservice.h 9983292 
  plasma/generic/dataengines/share/shareservice.cpp b789439 

Diff: http://git.reviewboard.kde.org/r/114263/diff/


Testing (updated)
-------

Doesn't build. Looks like an issue with the K_EXPORT_PLASMA_PACKAGE macro.


Thanks,

Andrea Scarpino

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131203/b75cd8dc/attachment.html>