Review Request 114260: Port mouse dataengine

[Bhushan Shah]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114260/#review45021
-----------------------------------------------------------


There is similar review request for it.. https://git.reviewboard.kde.org/r/112360/ Have you tested this with plasmaengineexplorer?


plasma/generic/dataengines/mouse/mouseengine.h
<http://git.reviewboard.kde.org/r/114260/#comment32198>

    Instead use K_EXPORT_PLASMA_DATAENGINE_WITH_JSON macro.



plasma/generic/dataengines/mouse/mouseengine.cpp
<http://git.reviewboard.kde.org/r/114260/#comment32199>

    Remove this here and there; it's not needed


- Bhushan Shah


On Dec. 3, 2013, 12:52 a.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114260/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2013, 12:52 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> = subject.
> 
> I commented the lines about scheduleSourcesUpdated(). What to do with them?
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/mouse/mouseengine.h d55565d 
>   plasma/generic/dataengines/mouse/mouseengine.cpp 19a7fb7 
>   plasma/generic/dataengines/mouse/cursornotificationhandler.cpp 3cb9add 
>   plasma/generic/dataengines/mouse/cursornotificationhandler.h 3b571f8 
>   plasma/generic/dataengines/mouse/CMakeLists.txt 29cab87 
>   plasma/generic/dataengines/CMakeLists.txt 3e94325 
> 
> Diff: http://git.reviewboard.kde.org/r/114260/diff/
> 
> 
> Testing
> -------
> 
> Builds
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131203/f640dd35/attachment-0001.html>