Review Request 114200: Add include for klocalizedstring in klocale.h

[Stephen Kelly]

> On Nov. 29, 2013, 12:28 p.m., Albert Astals Cid wrote:
> > No, in KDE4 times, you got KLocalizedString though klocalizedstring.h, if people is including KLocale just for KLocalizedString that's "wrong" and i think adding this include is doing people a dis-service by maing think they depend on a tier4 framework when maybe they don't.
> 
> Martin Gräßlin wrote:
>     Than it's for code from kde3 times or older. The idea is to make porting easier. I think everybody wants to get rid of kde4support and everybody needs to have kde4support in the first step. As an example I'm just porting ksysguard. It nowhere included klocalizedstring. Everywhere it was klocale, but nothing of klocale was used.
>     
>     It's not possible to just do a replace of klocale by klocalizedstring in the porting scripts as it's possible that the source file uses KLocale. It's a compile, error, fix, compile game.

I agree with Martin.


- Stephen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114200/#review44796
-----------------------------------------------------------


On Nov. 29, 2013, 12:22 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114200/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2013, 12:22 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> One of the most often porting error I get is the lack of the KLocalizedString include. In KDE4 times this was through klocale. So most files have an include to klocale, but it is not used at all.
> 
> By adding this include to klocale.h we can significantly decrease the initial "get-it-compile-pain".
> 
> 
> Diffs
> -----
> 
>   tier4/kde4support/src/kdecore/klocale.h 1c446fe 
> 
> Diff: http://git.reviewboard.kde.org/r/114200/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131201/a44ecb99/attachment.html>