Review Request 112331: Splitting KUnitConversion
Aleix Pol Gonzalez
aleixpol at kde.org
Sat Aug 31 16:11:10 UTC 2013
> On Aug. 31, 2013, 7:01 a.m., David Faure wrote:
> > Solid seems like a "big" dependency just to know if we're online.
> > I would either
> > 1) keep the ifdefs for solid, so that someone can easily compile it without solid for his own purposes, or
> > 2) port it to QNetworkInterface (I didn't know about QNetworkSession, it looks more like a mobile thing?).
I dropped solid dependency
- Aleix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112331/#review38983
-----------------------------------------------------------
On Aug. 28, 2013, 4:17 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112331/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2013, 4:17 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Iterates over KUnitConversion, still not final:
> - Stops using KDE_PLATFORM_FEATURE_BINARY_COMPATIBLE_FEATURE_REDUCTION
> - Makes dependencies fixed:
> - Removes runtime dependency on kioclient and links to Qt5::Network instead (adding a dependency to QtNetwork)
> - Removes the ifdef and always depends on Solid for checking whether it's online. This dependency could go if we move it to QNetworkSession, if somebody thinks it makes sense, I can open a task for that.
> - Removes kunitconversion-config.h, there are not different ways to build it now.
>
>
> Diffs
> -----
>
> staging/kunitconversion/src/kunitconversion/CMakeLists.txt c9272ab
> staging/kunitconversion/src/kunitconversion/acceleration.cpp 1a22330
> staging/kunitconversion/src/kunitconversion/angle.cpp 31999b0
> staging/kunitconversion/src/kunitconversion/area.cpp c84ffd1
> staging/kunitconversion/src/kunitconversion/config-kunitconversion.h.cmake 601dc1c
> staging/kunitconversion/src/kunitconversion/converter.cpp a433240
> staging/kunitconversion/src/kunitconversion/currency.cpp 16c7fb2
> staging/kunitconversion/src/kunitconversion/density.cpp 878f199
> staging/kunitconversion/src/kunitconversion/energy.cpp 7e5f8b3
> staging/kunitconversion/src/kunitconversion/force.cpp d933a9f
> staging/kunitconversion/src/kunitconversion/frequency.cpp 55a99e9
> staging/kunitconversion/src/kunitconversion/fuel_efficiency.cpp 6b16696
> staging/kunitconversion/src/kunitconversion/kcurrencycode.cpp 09e40ac
> staging/kunitconversion/src/kunitconversion/length.cpp 29211d9
> staging/kunitconversion/src/kunitconversion/mass.cpp a8dc69c
> staging/kunitconversion/src/kunitconversion/power.cpp 30e123e
> staging/kunitconversion/src/kunitconversion/pressure.cpp ed849bb
> staging/kunitconversion/src/kunitconversion/temperature.cpp 982f6bb8
> staging/kunitconversion/src/kunitconversion/timeunit.cpp a9341c4
> staging/kunitconversion/src/kunitconversion/unit.cpp f8c6217
> staging/kunitconversion/src/kunitconversion/unitcategory.cpp c7aaf27
> staging/kunitconversion/src/kunitconversion/value.cpp 228ecfe
> staging/kunitconversion/src/kunitconversion/velocity.cpp 1e5c817
> staging/kunitconversion/src/kunitconversion/volume.cpp 02d8eee
>
> Diff: http://git.reviewboard.kde.org/r/112331/diff/
>
>
> Testing
> -------
>
> Builds, unit tests pass.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130831/625d74e6/attachment.html>
More information about the Kde-frameworks-devel
mailing list