Review Request 112401: Let ki18n report the list of available translations of the application

Aleix Pol Gonzalez aleixpol at kde.org
Sat Aug 31 12:18:03 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112401/#review39006
-----------------------------------------------------------



staging/ki18n/src/klocalizedstring.cpp
<http://git.reviewboard.kde.org/r/112401/#comment28775>

    Maybe this could be a QSet<QString>?
    
    You're doing many sorts that we can probably delay anyway (in case it's even needed).


- Aleix Pol Gonzalez


On Aug. 31, 2013, 11:44 a.m., Chusslove Illich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112401/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2013, 11:44 a.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid and Aleix Pol Gonzalez.
> 
> 
> Description
> -------
> 
> Add the static method KLocalizedString::availableApplicationTranslations
> that reports the list of language codes for which there exists the
> translation catalog for application's domain (as set by
> KLocalizedString::setApplicationDomain). This allows client code e.g. to
> offer a language switching feature in an application.
> 
> 
> Diffs
> -----
> 
>   staging/ki18n/autotests/klocalizedstringtest.cpp ec3966f 
>   staging/ki18n/src/kcatalog.cpp 183bea5 
>   staging/ki18n/src/kcatalog_p.h 6feb09c 
>   staging/ki18n/src/klocalizedstring.h eb44075 
>   staging/ki18n/src/klocalizedstring.cpp eab9216 
> 
> Diff: http://git.reviewboard.kde.org/r/112401/diff/
> 
> 
> Testing
> -------
> 
> Unit test supplied.
> 
> 
> Thanks,
> 
> Chusslove Illich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130831/10c81c7d/attachment.html>


More information about the Kde-frameworks-devel mailing list