Review Request 112311: Port kmimetypechooser.cpp from Krun to QProcess

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112311/#review38971
-----------------------------------------------------------



kio/kio/kmimetypechooser.cpp
<http://git.reviewboard.kde.org/r/112311/#comment28743>

    This include can now be removed, right?



kio/kio/kmimetypechooser.cpp
<http://git.reviewboard.kde.org/r/112311/#comment28741>

    This kills the keditfiletype dialog when closing the mimetypechooser dialog. Previously this wouldn't happen.
    
    How about creating the QProcess on the stack and using startDetached(), so the two processes are independent?



kio/kio/kmimetypechooser.cpp
<http://git.reviewboard.kde.org/r/112311/#comment28742>

    QStringLiteral()


- David Faure


On Aug. 27, 2013, 2:30 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112311/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2013, 2:30 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Title says it all
> 
> 
> Diffs
> -----
> 
>   kio/kio/kmimetypechooser.cpp 616b033 
> 
> Diff: http://git.reviewboard.kde.org/r/112311/diff/
> 
> 
> Testing
> -------
> 
> Tested by running kmimetypechoosertest, the behavior is same with or without this patch.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130830/5eaf1b19/attachment-0001.html>