Review Request 112367: Include the icon's theme in the cache key

Michael Pyne mpyne at kde.org
Fri Aug 30 22:49:08 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112367/#review38968
-----------------------------------------------------------

Ship it!


Well, why not commit it now, and if it ends up slow we can revert it later? We can at least be correct in KF5 while we wait for the rest of the frameworks to catch up. :)

- Michael Pyne


On Aug. 29, 2013, 8 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112367/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2013, 8 p.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs and Michael Pyne.
> 
> 
> Description
> -------
> 
> If we make no difference between an icon from oxygen and an icon from
> gnome, when we change themes for example from oxygen to gnome, the
> icon will be found in the cache and won't be upgraded.
> 
> 
> Diffs
> -----
> 
>   kdeui/icons/kiconloader.cpp ce6aeea 
> 
> Diff: http://git.reviewboard.kde.org/r/112367/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130830/a2f62e29/attachment.html>


More information about the Kde-frameworks-devel mailing list