Review Request 112367: Include the icon's theme in the cache key

Aleix Pol Gonzalez aleixpol at kde.org
Thu Aug 29 22:55:11 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112367/#review38905
-----------------------------------------------------------


Yes it makes sense, although probably we should just nuke the cache whenever the theme is changed. The cache is not useful anymore after a theme change.

- Aleix Pol Gonzalez


On Aug. 29, 2013, 8 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112367/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2013, 8 p.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs and Michael Pyne.
> 
> 
> Description
> -------
> 
> If we make no difference between an icon from oxygen and an icon from
> gnome, when we change themes for example from oxygen to gnome, the
> icon will be found in the cache and won't be upgraded.
> 
> 
> Diffs
> -----
> 
>   kdeui/icons/kiconloader.cpp ce6aeea 
> 
> Diff: http://git.reviewboard.kde.org/r/112367/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130829/b096dd4b/attachment.html>


More information about the Kde-frameworks-devel mailing list