Review Request 112353: An attempt to fix sometimes failing KArchive test

[Mario Bensi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112353/#review38834
-----------------------------------------------------------

Ship it!


Ship It!

- Mario Bensi


On Aug. 29, 2013, 10:13 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112353/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2013, 10:13 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> One of the KArchive tests is to compare if the time of creating the archive file is the same as the time of a file inside of the archive. This can occasionally fail thanks to some msecs delay between the operations followed by rounding to seconds, so the times that are being compared can end up as "18:31:00" and "18:31:01", which then fails the test.
> 
> What I did is to take the time part out of the comparison and do a separate comparison of the times with allowed 1 sec difference.
> 
> 
> Diffs
> -----
> 
>   tier1/karchive/autotests/karchivetest.cpp 0b2ecdd 
> 
> Diff: http://git.reviewboard.kde.org/r/112353/diff/
> 
> 
> Testing
> -------
> 
> 100% pass of KArchive tests in 10 consecutive runs.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130829/373daac0/attachment.html>