Review Request 112324: Adjust to QCommandLineParser as it ended in Qt

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112324/#review38779
-----------------------------------------------------------

Ship it!


Looks fine, thanks!

Just one thing that could be done on top, to finish the port.


kross/console/main.cpp
<http://git.reviewboard.kde.org/r/112324/#comment28649>

    this can now be parser.addPositionalArgument()



kross/test/main.cpp
<http://git.reviewboard.kde.org/r/112324/#comment28650>

    same here



staging/kdoctools/src/meinproc.cpp
<http://git.reviewboard.kde.org/r/112324/#comment28648>

    this TODO has been implemented now, it should be parser.addPositionalArgument()


- David Faure


On Aug. 28, 2013, 8 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112324/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2013, 8 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   kded/kbuildsycoca.cpp b376a3c 
>   kdewidgets/makekdewidgets.cpp 38c1c98 
>   kio/misc/ksendbugmail/main.cpp b3fb49b 
>   kio/tests/kioslavetest.cpp 4a02a57 
>   kioslave/http/http_cache_cleaner.cpp c3c23fc 
>   kioslave/http/kcookiejar/main.cpp c64bf9c 
>   kross/console/main.cpp 7591199 
>   kross/qts/main.cpp effc5bb 
>   kross/test/main.cpp 26da9e2 
>   libkdeqt5staging/src/qcommandlineoption.h a7c6b11 
>   libkdeqt5staging/src/qcommandlineoption.cpp fd22883 
>   libkdeqt5staging/src/qcommandlineparser.h 21e8f33 
>   libkdeqt5staging/src/qcommandlineparser.cpp f63c5f3 
>   staging/kdoctools/src/meinproc.cpp 74f12a2 
>   staging/knotifications/tests/kstatusnotifieritemtest.cpp 9532895 
>   staging/kservice/src/desktoptojson/main.cpp eb67d1c 
>   tier1/kconfig/src/kconf_update/kconf_update.cpp 12e3188 
> 
> Diff: http://git.reviewboard.kde.org/r/112324/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130828/2eb8379e/attachment.html>