Review Request 112292: Make KLocalizedString::isApplicationTranslatedInto and QLocale::uiLanguages compatible

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112292/
-----------------------------------------------------------

(Updated Aug. 27, 2013, 1:14 p.m.)


Review request for KDE Frameworks, Albert Astals Cid, Aleix Pol Gonzalez, and Chusslove Illich.


Changes
-------

The country code can sometimes be of 3 letters, so it's better to rely on the script length (4) in order to disambiguate between the two.


Description
-------

    Make KLocalizedString::isApplicationTranslatedInto & QLocale::uiLanguages compatible
    
    QLocale::uiLanguages returns "lang-script-country" whereas KCatalog
    expects the format to be "lang_countr at script". We need to convert the
    format before checking if the corresponding catalog exists.


Diffs (updated)
-----

  staging/ki18n/src/klocalizedstring.cpp eab9216 

Diff: http://git.reviewboard.kde.org/r/112292/diff/


Testing
-------

Limited testing done. My QLocale::uiLanguages() returns "en-US" which is correctly converted to "en_US". I haven't tested it with anything else. Any tips on how I should go about testing this?


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130827/749c5004/attachment.html>