KEmoticons splitting task

[David Gil Oliva]

Hello,

I took the KEmoticons splitting task. I'm studying the code and I have
found many issues:

--KEmoticonsProvider should be abstract, since its virtual methods either
don't do anything or their code is not safe.

--Many KEmoticons tests don't pass (I haven't actually changed anything
yet). And kdelibs-frameworks/staging/kemoticons/tests/main.cpp doesn't
parse correctly the emoticons. It says 'kemoticonstest(2650)/default
KEmoticonsPrivate::loadProvider: Invalid plugin factory for
"emoticonstheme_kde"'. I suspect that the uses of KPluginLoader have to be
substituted by QPluginLoader in order to work correctly. Could I be right?

--The API method names could be improved to be clearer. I don't know
whether to deprecate the old ones or simply substitute them. What's better?

--KEmoticonsProvider includes <kio/copyjob.h> and <kio/jobuidelegate.h>. Is
this OK?

First I'll try to fix the
kdelibs-frameworks/staging/kemoticons/tests/main.cpp test to be able to
know where the problems are when parsing. Then I'll modify the framework to
be as well written as I can and to have all tests passed. Finally I'll
split it into tier3 folder. I'll send little patches to RB.

Cheers,

David Gil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130826/c5eaaad7/attachment.html>