Review Request 112288: fillApplicationLanguages: Do not add the system locale

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112288/#review38652
-----------------------------------------------------------

Ship it!



staging/xmlgui/src/kswitchlanguagedialog_p.cpp
<http://git.reviewboard.kde.org/r/112288/#comment28582>

    You could have used QLocale::c() too.


- Kevin Ottens


On Aug. 26, 2013, 2:34 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112288/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2013, 2:34 p.m.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Description
> -------
> 
>     If QLocale cannot find the appropriate language, it then defaults to the
>     system locale. When adding all possible languages it is possible that
>     QLocale::system() is added multiple times. This results in a huge list
>     for the default language being added.
>     
>     For me, "US English" gets added over 50 times.
> 
> 
> Diffs
> -----
> 
>   staging/xmlgui/src/kswitchlanguagedialog_p.cpp 894f2f4 
> 
> Diff: http://git.reviewboard.kde.org/r/112288/diff/
> 
> 
> Testing
> -------
> 
> Ran kwindowtest and compared the list of languages shown in the switch languages dialog.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130826/f66c8169/attachment.html>