Review Request 112282: Move platformHints into their own class

Commit Hook null at kde.org
Mon Aug 26 14:34:26 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112282/#review38649
-----------------------------------------------------------


This review has been submitted with commit a1241501a4283152ab755de81848fa96be3db020 by Àlex Fiestas to branch frameworks.

- Commit Hook


On Aug. 26, 2013, 12:58 a.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112282/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2013, 12:58 a.m.)
> 
> 
> Review request for KDE Frameworks and Kevin Ottens.
> 
> 
> Description
> -------
> 
> With all the updating logic, palette will become complex, so we better
> move it into another class before starting to make KdePlatformTheme
> bloated.
>     
> Also makes more sense when creating unittest.
> 
> 
> Diffs
> -----
> 
>   staging/frameworkintegration/autotests/CMakeLists.txt 25fd48e 
>   staging/frameworkintegration/src/platformtheme/CMakeLists.txt 4130e33 
>   staging/frameworkintegration/src/platformtheme/kdeplatformtheme.h 1a5c057 
>   staging/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp 31d5479 
>   staging/frameworkintegration/src/platformtheme/khintssettings.h PRE-CREATION 
>   staging/frameworkintegration/src/platformtheme/khintssettings.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112282/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130826/f7f49a84/attachment.html>


More information about the Kde-frameworks-devel mailing list