Review Request 112279: Call the correct static Q[Gui]Application::setFont

Kevin Ottens ervin at kde.org
Mon Aug 26 13:25:05 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112279/#review38635
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On Aug. 26, 2013, 12:05 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112279/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2013, 12:05 p.m.)
> 
> 
> Review request for KDE Frameworks and Kevin Ottens.
> 
> 
> Description
> -------
> 
> When fonts changes, call the correct static depending whether the
> QCoreApplication::instance is a QApplication or QGuiApplication.
>     
> The reason why QGuiApplication is not enough is because we need to
> propagate/send a QEvent to each Widget to make them aware that the
> font has changed and QGuiApplication know nothing about widgets
> 
> 
> Diffs
> -----
> 
>   staging/frameworkintegration/src/platformtheme/kfontsettingsdata.cpp 70c1d26 
> 
> Diff: http://git.reviewboard.kde.org/r/112279/diff/
> 
> 
> Testing
> -------
> 
> Tested fontChange with QApplication and QGuiApplication
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130826/0f3e2c99/attachment.html>


More information about the Kde-frameworks-devel mailing list