Review Request 112288: fillApplicationLanguages: Do not add the system locale
Vishesh Handa
me at vhanda.in
Mon Aug 26 13:06:22 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112288/
-----------------------------------------------------------
Review request for KDE Frameworks and Aleix Pol Gonzalez.
Description
-------
If QLocale cannot find the appropriate language, it then defaults to the
system locale. When adding all possible languages it is possible that
QLocale::system() is added multiple times. This results in a huge list
for the default language being added.
For me, "US English" gets added over 50 times.
Diffs
-----
staging/xmlgui/src/kswitchlanguagedialog_p.cpp 894f2f4
Diff: http://git.reviewboard.kde.org/r/112288/diff/
Testing
-------
Ran kwindowtest and compared the list of languages shown in the switch languages dialog.
Thanks,
Vishesh Handa
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130826/b4e5a5aa/attachment.html>
More information about the Kde-frameworks-devel
mailing list