Review Request 112175: Implement Ctrl+Enter dialog acceptation in KStyle::polish()

Commit Hook null at kde.org
Mon Aug 26 10:33:13 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112175/
-----------------------------------------------------------

(Updated Aug. 26, 2013, 10:33 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Description
-------

Make it possible to make sure that we keep reacting properly to ctrl+enter after switching from QDialog to KDialog by intercepting QDialogButtonBox creation and injecting the desired shortcut to it.


Diffs
-----

  KDE5PORTING.html bbc1c41 
  staging/frameworkintegration/CMakeLists.txt 2ffd732 
  staging/frameworkintegration/src/kstyle/CMakeLists.txt 265eff4 
  staging/frameworkintegration/src/kstyle/kstyle.cpp 63506476 
  staging/frameworkintegration/tests/CMakeLists.txt PRE-CREATION 
  staging/frameworkintegration/tests/kstyletest.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112175/diff/


Testing
-------

Created a "kstyletest" that shows a dialog with a text edit and makes sure that this works.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130826/8b217667/attachment.html>


More information about the Kde-frameworks-devel mailing list