Review Request 112217: copy KStyle as K4Style in KDE4Support

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112217/#review38572
-----------------------------------------------------------



KDE5PORTING.html
<http://git.reviewboard.kde.org/r/112217/#comment28522>

    "Original KStyle class have been trimmed down" sounds misleading to me.
    The "original KStyle" was copied as K4Style in KDE4Support. While we can consider KStyle as a new one seeing the amount of changes it will get. So probably needs to be reworded there.
    
    Also you got an unwanted space at the end of that line.


- Kevin Ottens


On Aug. 22, 2013, 11:34 p.m., Wojciech Kapuscinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112217/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2013, 11:34 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> kdelibs_cleanup task: KStyle 1/3: Copy KStyle as K4Style in KDE4Support 
> 
> I cannot upload patch generated with --find-copies-harder (it works if file was moved but not when copied) so I attached patch with --find-copies-harder
> 
> 
> Diffs
> -----
> 
>   KDE5PORTING.html bbc1c41 
>   staging/kde4support/src/CMakeLists.txt ba56061 
>   staging/kde4support/src/kdeui/k4style.h PRE-CREATION 
>   staging/kde4support/src/kdeui/k4style.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112217/diff/
> 
> 
> Testing
> -------
> 
> it builds and tests looks OK
> 
> 
> File Attachments
> ----------------
> 
> patch generated with --find-copies-harder
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/k4style.patch
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130826/e6618e5c/attachment-0001.html>