Review Request 112174: Make KSharedConfig::Ptr use QExplicitlySharedDataPointer

David Faure faure at kde.org
Wed Aug 21 14:06:05 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112174/#review38275
-----------------------------------------------------------

Ship it!


(after discussing on IRC that all unittests pass as before)

- David Faure


On Aug. 20, 2013, 4:48 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112174/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2013, 4:48 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Make KSharedConfig::Ptr use QExplicitlySharedDataPointer
> 
> QExplicitlySharedDataPointer does the same as KSharedPtr with only
> slightly different API
> 
> 
> Diffs
> -----
> 
>   staging/kde4attic/src/localization/klocale_kde.cpp 2ad32083f8f7e59d140acbbf02766bf638c4207b 
>   staging/kde4support/src/kdecore/kcomponentdata.cpp 9c9e50904cd8663ec676e36bfed8e74ab3c1db19 
>   staging/kde4support/src/kdecore/kglobal.h 056847f5152dcd1dd32e953d88b57c79c799fab1 
>   staging/kio/src/core/kprotocolmanager.h cb370358cb5c4b789cd3431ae0b82cc6708c20b7 
>   tier1/kconfig/src/core/kconfiggroup.h 928b64d933a54c33456cdacc41fea83a7a36e046 
>   tier1/kconfig/src/core/ksharedconfig.h b8f0175e5b2a81fc677286786ea4327695917e65 
> 
> Diff: http://git.reviewboard.kde.org/r/112174/diff/
> 
> 
> Testing
> -------
> 
> Builds and installs
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130821/610ecc04/attachment.html>


More information about the Kde-frameworks-devel mailing list