Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

[David Gil Oliva]

> On Aug. 20, 2013, 9:27 a.m., David Faure wrote:
> > staging/kio/src/core/authinfo.cpp, line 545
> > <http://git.reviewboard.kde.org/r/111636/diff/3/?file=183588#file183588line545>
> >
> >     let's hope macdef always comes *after* machine, otherwise index won't be set yet at this point...
> >     
> >     you should at least initialized index to -1 in the constructor, for a clear crash (assert) rather than un-repeatable behavior (use of uninit memory) in case this happens.

>From what I've seen, macdef comes after the machine it belongs to. I've fixed it anyway.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111636/#review38190
-----------------------------------------------------------


On Aug. 19, 2013, 9:41 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111636/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2013, 9:41 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Port away from kde_file.h in AuthInfo (KIO)
> 
> 
> Diffs
> -----
> 
>   staging/kio/src/core/authinfo.h d6415b2f2e9ccec7c3e046f569fb44dbbc879d6b 
>   staging/kio/src/core/authinfo.cpp 65ebacf84e989f19f1b896c596a6b24185c67447 
> 
> Diff: http://git.reviewboard.kde.org/r/111636/diff/
> 
> 
> Testing
> -------
> 
> It builds. I have tested the part of the code not related to loginMap with a little program and .netrc sample files, to check whether it correctly parses the information.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130820/d4e840b9/attachment-0001.html>